Adds support for WiredTiger Engine#61
Conversation
|
do you need any help with working through the rubocop issues? |
|
Looks like we need a reabse. Let me know if you need any help working through CI issues. |
|
@parin921996 any chance you plan on coming back to this? |
|
@majormoses I have kinda lost track of this one , i will try to fix it by this weekend . |
|
@majormoses Hey I have Fixed the issue , I will create new PR for any new metrics introduced in mongo 3.4 and above. |
majormoses
added
Type: Enhancement
Status: Needs Review
Area: Metric
and removed
Status: Awaiting Response
Status: Needs Rebase
labels
|
Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly. |
majormoses
left a comment
majormoses
left a comment
There was a problem hiding this comment.
Overall I think this looks really good just a couple of improvements and some nitpicks and we are good to go.
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [2.0.3] - 2018-09-14 |
There was a problem hiding this comment.
In general the versioning and dating are left to the maintainers for several reasons:
- we may disagree on the impact of the change and therefore how its versioned (in this case it would be a minor so it would be
2.1.0) per our versioning guidelines - we date the release rather then when the contribution was submitted, PR review and acceptance has no SLA and is not guaranteed to be merged within the same day
- PRs are not a FIFO queue, as such versioning them prior to acceptance leads to needing to ask people to rebase more often
| ## [Unreleased] | ||
|
|
||
| ## [2.0.3] - 2018-09-14 | ||
| ### New Feature |
There was a problem hiding this comment.
When adding a new feature we use the ### Added header
| wiredtiger[key1].each do |key2, value2| | ||
| if value2.is_a? Hash | ||
| wiredtiger[key1][key2].each do |key3, value3| | ||
| server_metrics['wiredTiger.' + key1.gsub(/(,|\s|-|\()+/, '_').tr(')', '') + '.' + |
There was a problem hiding this comment.
it looks like we are repeating the same logic/regex here can we make a function and call that instead I think it would make the code a lot more readable. Maybe something along the lines of wiretiger_metric_(converter|builder|formatter)
There was a problem hiding this comment.
I was thinking to write json flattener but current use case was quite specific so I quickly submit this PR. But I kinda liked the idea.
|
@parin921996 any chance you have some systems to test #55 with? I'd really like to see both of these over the line. |
I dont have any replica set running locally.. |
2 participants
Pull Request Checklist
Is this in reference to an existing issue?
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Known Compatibility Issues