Skip to content

Conversation

@jspaleta
Copy link
Contributor

Closes #1

@kmf
Copy link

kmf commented May 19, 2022

will this be merged?

@jspaleta
Copy link
Contributor Author

will this be merged?

Let me clean this up and line up specific reviewers. Hopefully next week. I generally don't want to Yolo merge my own PRs unless its a critical bug fix.

@jspaleta jspaleta self-assigned this Jun 17, 2022
@jspaleta jspaleta requested a review from echlebek June 17, 2022 18:47
@jspaleta
Copy link
Contributor Author

I already know I need to do a little more work on this before its gonna pass review. I need to add some test coverage. We'll get in probably late next week.

@jspaleta
Copy link
Contributor Author

other higher priority items came up. I'm at monitorama next week but I'll try to make sure if I have time while there to do any technical work I'll on getting this brushed up.

Here's my plan when i get the round toits to work on this.
I'm going to commit this, but I'm going to open up a new PR to add test coverage for the new functions before I tag a release with this change.

@echlebek
Copy link
Contributor

@jspaleta sounds good, but please clean up the merge artifacts in CHANGELOG.md

@jspaleta
Copy link
Contributor Author

haha... no i totally missed this is MY pr branch... no need for a new PR.. im gonna work in this one. I though this was a PR from a repo fork.

@jspaleta
Copy link
Contributor Author

@echlebek
Okay I have the test coverage sorted out.

In particular I've added test cases for the adjPercent function to make sure its doing the sane expected behavior pushing the percentage threshold limits up/down according to whether the file system is smaller/larger than the "normal" filesystem size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement magic functionality for larger volumes

3 participants