Skip to content

Conversation

@rakibhossainctr
Copy link

@rakibhossainctr rakibhossainctr commented Jul 16, 2025

What is this change?

  1. Updating agent events to carry FallbackPipeline to backend
  2. Updating GetAssets to raise errors on missing runtime assets

Why is this change necessary?

When the execution of a workflow pipe handler results in an error (e.g. fork/exec failure), the error is logged and any other workflows in the pipeline are skipped. This does not include pipe handlers that return a non-zero exit status. The AdapterV1 Pipeline Adapter does not currently distinguish between zero and non-zero exit statuses. The remaining workflows are also skipped if the execution of a filter or mutator results in an error.

Does your change need a Changelog entry?

NA

Do you need clarification on anything?

NA

Were there any complications while making this change?

  • refactoring was required

Have you reviewed and updated the documentation for this change? Is new documentation required?

NA

How did you verify this change?

  1. Created handler with non-zero status (wrong command) and verified

Is this change a patch?

NA

@chavakula
Copy link

@rakibhossainctr test cases are failing, please check

@chavakula
Copy link

@rakibhossainctr need to add latest core/V2 version in go.mod

Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
…dler execution as error

Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Copy link
Member

@amdprophet amdprophet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop execution of asset consumers if asset.GetAssets() or asset.GetAll() errors

4 participants