Validate runtime assets #5121
Open
Validate runtime assets #5121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
rakibhossainctr
force-pushed
the
validate_runtime_assets
branch
from
f9dceec to
7d498c9
Compare
fguimond
reviewed
Sep 25, 2025
fguimond
reviewed
Sep 25, 2025
fguimond
reviewed
Sep 25, 2025
fguimond
reviewed
Sep 25, 2025
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Signed-off-by: rakibhossainctr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Adds backend-side validation for runtime_assets in CheckConfig creation and update.
If any referenced asset does not exist in the namespace, the request will be rejected with a validation error.
Why is this change necessary?
Previously, Sensu allowed creating a CheckConfig with non-existent assets, leading to runtime execution failures that were only visible in logs.
This change improves usability by detecting missing or invalid assets during check creation/update, preventing avoidable runtime errors and debugging overhead.
Does your change need a Changelog entry?
Yes — this is a user-facing change in validation behavior for check creation/update.
Do you need clarification on anything?
No.
Were there any complications while making this change?
No major complications
Have you reviewed and updated the documentation for this change? Is new documentation required?
Yes
How did you verify this change?
Added unit tests for check creation/update with:
Verified via sensuctl create that creation fails with a clear error message when missing assets are referenced.
Is this change a patch?
No