Add Windows-only test for libedax initialization with non-ASCII book file paths#902
Merged
Merged
Conversation
Co-authored-by: sensuikan1973 <23427957+sensuikan1973@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Windows-only test for libedax initialization with non-ASCII paths
Add Windows-only test for libedax initialization with non-ASCII book file paths
Mar 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 82.56% 82.84% +0.28%
==========================================
Files 15 15
Lines 780 793 +13
==========================================
+ Hits 644 657 +13
Misses 136 136
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… for libedax args. Keeps edax-reversi C code unchanged while fixing non-ASCII path handling on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies that libedax can initialize correctly when the book file path contains non-ASCII characters — a scenario relevant to Windows users with non-Latin system locales or usernames.
Changes
test/edax_command_test.dart: Added aPlatform.isWindows-gated test group that:非ASCII_) underDirectory.systemTempresources/test_book.datinto it as本.datfinallyOriginal prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.