Skip to content

yarn upgrade --latest && yarn build#2682

Merged
sensuikan1973 merged 1 commit into
mainfrom
upgrade_website_dependencies
Jul 18, 2025
Merged

yarn upgrade --latest && yarn build#2682
sensuikan1973 merged 1 commit into
mainfrom
upgrade_website_dependencies

Conversation

@sensuikan1973

Copy link
Copy Markdown
Owner

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies. A potential issue has been identified with the @types/node version, which may not be available on the public npm registry. This should be investigated to prevent potential build failures.

Comment thread website/yarn.lock
Comment on lines +2400 to +2402
version "24.0.14"
resolved "https://registry.yarnpkg.com/@types/node/-/node-24.0.14.tgz#6e3d4fb6d858c48c69707394e1a0e08ce1ecc1bc"
integrity sha512-4zXMWD91vBLGRtHK3YbIoFMia+1nqEz72coM42C5ETjnNCa/heoj7NT1G67iAfOqMmcfhuCZ4uNpyz8EjlAejw==

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The update changes the resolved version of @types/node to 24.0.14. This version does not appear to be available on the public npm registry. This discrepancy could cause yarn install to fail in clean environments, potentially breaking the build.

@codecov

codecov Bot commented Jul 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (63a8a6f) to head (9cf246d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2682   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          52       52           
  Lines        1477     1477           
=======================================
  Hits         1388     1388           
  Misses         89       89           
Flag Coverage Δ
integration_test 65.40% <ø> (ø)
macos-latest 93.02% <ø> (ø)
ubuntu 93.43% <ø> (ø)
widget_test 90.31% <ø> (ø)
windows 93.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sensuikan1973 sensuikan1973 merged commit 61b9af5 into main Jul 18, 2025
24 checks passed
@sensuikan1973 sensuikan1973 deleted the upgrade_website_dependencies branch July 18, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant