Skip to content

mild fix capture board image shortcut#2836

Merged
sensuikan1973 merged 1 commit into
mainfrom
fix_broken_integartion_test
Jan 30, 2026
Merged

mild fix capture board image shortcut#2836
sensuikan1973 merged 1 commit into
mainfrom
fix_broken_integartion_test

Conversation

@sensuikan1973
Copy link
Copy Markdown
Owner

resolve #2835

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request includes important fixes that enhance both the reliability of integration tests and the robustness of the application's image capture functionality. The keyboard event simulation in tests has been made more accurate, and a critical check for the existence of temporary directories has been added to prevent potential file system errors during image saving. These changes improve the overall stability and correctness of the application.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.98%. Comparing base (21e8117) to head (d177cc1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2836   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files          52       52           
  Lines        1477     1479    +2     
=======================================
+ Hits         1388     1390    +2     
  Misses         89       89           
Flag Coverage Δ
integration_test 65.44% <100.00%> (+0.11%) ⬆️
macos-latest 93.03% <100.00%> (+2.64%) ⬆️
ubuntu 93.44% <100.00%> (+<0.01%) ⬆️
widget_test 90.26% <0.00%> (-0.13%) ⬇️
windows 93.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../pedax_shortcuts/capture_board_image_shortcut.dart 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sensuikan1973 sensuikan1973 merged commit 0533435 into main Jan 30, 2026
24 checks passed
@sensuikan1973 sensuikan1973 deleted the fix_broken_integartion_test branch January 30, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macos] flutter_integration_test fails

1 participant