upgrade nodejs version#2877
Conversation
There was a problem hiding this comment.
Code Review
This pull request proposes an upgrade of the Node.js version from 25.7.0 to 25.8.0 as defined in the .node-version file. While this change is straightforward, I have added a suggestion to also specify the Node.js version in the package.json engines field. This will improve consistency and help prevent potential issues for developers using different environment setups.
| @@ -1 +1 @@ | |||
| 25.7.0 | |||
| 25.8.0 | |||
There was a problem hiding this comment.
To ensure all developers use the correct Node.js version and to leverage built-in checks from package managers like npm and Yarn, it's a good practice to also specify the supported Node.js engine in your project's package.json file(s). This complements the .node-version file, which is often used by tools like nvm.
For example, you could add the following to website/package.json:
"engines": {
"node": ">=25.8.0"
}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 52 52
Lines 1483 1483
=======================================
Hits 1396 1396
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Pull request was closed
Auto-generated by create-pull-request
See: https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#triggering-further-workflow-runs