Skip to content

yarn upgrade --latest && yarn build#2881

Merged
sensuikan1973 merged 1 commit into
mainfrom
upgrade_website_dependencies
Mar 6, 2026
Merged

yarn upgrade --latest && yarn build#2881
sensuikan1973 merged 1 commit into
mainfrom
upgrade_website_dependencies

Conversation

@sensuikan1973

Copy link
Copy Markdown
Owner

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated dependency upgrade using yarn upgrade --latest. While keeping dependencies up-to-date is good practice, using --latest can be risky as it ignores the version ranges specified in package.json and may introduce breaking changes from major version updates. It's generally safer to use yarn upgrade which respects semantic versioning. I've also found a critical issue with the @types/node dependency which seems to point to a non-existent version, which will likely break the build.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment thread website/yarn.lock
Comment on lines 2744 to +2747
"@types/node@*":
version "25.3.2"
resolved "https://registry.yarnpkg.com/@types/node/-/node-25.3.2.tgz#cbc4b963e1b3503eb2bcf7c55bf48c95204918d1"
integrity sha512-RpV6r/ij22zRRdyBPcxDeKAzH43phWVKEjL2iksqo1Vz3CuBUrgmPpPhALKiRfU7OMCmeeO9vECBMsV0hMTG8Q==
version "25.3.5"
resolved "https://registry.yarnpkg.com/@types/node/-/node-25.3.5.tgz#beccb5915561f7a9970ace547ad44d6cdbf39b46"
integrity sha512-oX8xrhvpiyRCQkG1MFchB09f+cXftgIXb3a7UUa4Y3wpmZPw5tyZGTLWhlESOLq1Rq6oDlc8npVU2/9xiCuXMA==

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version for @types/node appears to be incorrect. The lockfile specifies version 25.3.5, but this version does not seem to exist in the public npm registry. The resolved URL https://registry.yarnpkg.com/@types/node/-/node-25.3.5.tgz is not accessible, which will likely cause yarn install to fail. Please investigate the automated process that generated this change. It's possible that a different dependency is causing this incorrect resolution, or there's an issue with the environment where this command was run.

@codecov

codecov Bot commented Mar 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (edabd34) to head (e4a876f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2881   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          52       52           
  Lines        1483     1483           
=======================================
  Hits         1396     1396           
  Misses         87       87           
Flag Coverage Δ
integration_test 65.00% <ø> (ø)
macos-latest 93.05% <ø> (ø)
ubuntu 93.59% <ø> (ø)
widget_test 90.28% <ø> (ø)
windows 93.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sensuikan1973 sensuikan1973 merged commit db6e72a into main Mar 6, 2026
24 checks passed
@sensuikan1973 sensuikan1973 deleted the upgrade_website_dependencies branch March 6, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant