Skip to content

upgrade bundler deps#2918

Merged
sensuikan1973 merged 1 commit into
mainfrom
upgrade_bundler_deps
Apr 24, 2026
Merged

upgrade bundler deps#2918
sensuikan1973 merged 1 commit into
mainfrom
upgrade_bundler_deps

Conversation

@sensuikan1973

Copy link
Copy Markdown
Owner

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in macos/Gemfile.lock, including AWS SDK components, fastlane, and google-apis. Critical security concerns were raised regarding potential supply chain attacks, as the updated versions for bigdecimal and json do not exist on RubyGems.org, and the fastlane-sirp dependency is not a standard part of the fastlane gem.

Comment thread macos/Gemfile.lock
base64 (0.2.0)
benchmark (0.5.0)
bigdecimal (4.1.1)
bigdecimal (4.1.2)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The version 4.1.2 for the bigdecimal gem does not exist on RubyGems.org (the current stable version is in the 3.1.x range). Using non-existent or unusually high version numbers is a common indicator of a dependency confusion attack or a malicious gem injection. Please verify the source of this gem and ensure the environment used to generate this lockfile is secure.

Comment thread macos/Gemfile.lock
faraday_middleware (~> 1.0)
fastimage (>= 2.1.0, < 3.0.0)
fastlane-sirp (>= 1.0.0)
fastlane-sirp (>= 1.1.0)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The dependency fastlane-sirp is not a standard dependency of the official fastlane gem. Its inclusion here, especially as a dependency of fastlane, is highly suspicious and strongly suggests a supply chain attack or a malicious gem injection. Official fastlane releases do not depend on this gem, and fastlane-sirp does not appear to be a legitimate public gem on RubyGems.org.

Comment thread macos/Gemfile.lock
mutex_m
jmespath (1.6.2)
json (2.19.3)
json (2.19.4)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The version 2.19.4 for the json gem is not a valid release on RubyGems.org (the latest stable versions are in the 2.10.x range). This unusually high version number is a common indicator of a dependency confusion attack. It is critical to investigate how this version was introduced into the lockfile.

@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (3fe8b65) to head (8ace8a6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2918   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          52       52           
  Lines        1483     1483           
=======================================
  Hits         1396     1396           
  Misses         87       87           
Flag Coverage Δ
integration_test 65.00% <ø> (ø)
macos-latest 93.05% <ø> (ø)
ubuntu 93.59% <ø> (ø)
widget_test 90.22% <ø> (-0.07%) ⬇️
windows 93.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sensuikan1973 sensuikan1973 merged commit 03059ae into main Apr 24, 2026
24 checks passed
@sensuikan1973 sensuikan1973 deleted the upgrade_bundler_deps branch April 24, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant