Skip to content

upgrade ruby and bundler version#2921

Merged
sensuikan1973 merged 1 commit into
mainfrom
upgrade_ruby_and_bundler_version
May 1, 2026
Merged

upgrade ruby and bundler version#2921
sensuikan1973 merged 1 commit into
mainfrom
upgrade_ruby_and_bundler_version

Conversation

@sensuikan1973
Copy link
Copy Markdown
Owner

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Bundler version in macos/Gemfile.lock from 4.0.10 to 4.0.11. Feedback points out that version 4.0.11 is non-standard for Bundler and notes that the expected Ruby version upgrade mentioned in the pull request context is not reflected in the code changes.

Comment thread macos/Gemfile.lock

BUNDLED WITH
4.0.10
4.0.11
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Bundler version 4.0.11 specified in BUNDLED WITH is non-standard, as the current stable release of Bundler is in the 2.x range. Using a non-existent or custom version can lead to compatibility issues for other developers and CI environments. Additionally, while the pull request title mentions a Ruby upgrade, no changes to the Ruby version are visible in the lockfile or the associated Gemfile. If a Ruby upgrade was intended, consider explicitly defining the version in the Gemfile (e.g., ruby '3.4.1') to ensure consistency across all environments.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (4379d65) to head (628eb78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2921   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          52       52           
  Lines        1483     1483           
=======================================
  Hits         1396     1396           
  Misses         87       87           
Flag Coverage Δ
integration_test 65.00% <ø> (ø)
macos-latest 93.05% <ø> (ø)
ubuntu 93.59% <ø> (ø)
widget_test 90.22% <ø> (-0.07%) ⬇️
windows 93.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sensuikan1973 sensuikan1973 merged commit 17986b9 into main May 1, 2026
31 of 32 checks passed
@sensuikan1973 sensuikan1973 deleted the upgrade_ruby_and_bundler_version branch May 1, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant