Skip to content

mild enhancements of CI/CD#2924

Merged
sensuikan1973 merged 3 commits into
mainfrom
mild_enhancement
May 2, 2026
Merged

mild enhancements of CI/CD#2924
sensuikan1973 merged 3 commits into
mainfrom
mild_enhancement

Conversation

@sensuikan1973
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a .gitattributes file to mark generated Dart files as linguist-generated, which helps in managing how these files are displayed in diffs. The review feedback suggests adding * text=auto to the file to ensure consistent line-ending handling across different operating systems.

Comment thread .gitattributes
Comment on lines +1 to +2
*.g.dart linguist-generated=true
*.freezed.dart linguist-generated=true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a cross-platform project, it is a best practice to define the default line-ending behavior in .gitattributes. Adding * text=auto ensures that Git handles line endings consistently across different operating systems (Windows, macOS, Linux), which prevents 'phantom' diffs and potential issues in CI/CD pipelines caused by CRLF/LF mismatches.

* text=auto
*.g.dart linguist-generated=true
*.freezed.dart linguist-generated=true

@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (2fe3d9b) to head (bcbf178).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2924   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          52       52           
  Lines        1483     1483           
=======================================
  Hits         1396     1396           
  Misses         87       87           
Flag Coverage Δ
integration_test 65.00% <ø> (ø)
macos-latest 93.05% <ø> (ø)
ubuntu 93.59% <ø> (ø)
widget_test 90.28% <ø> (+0.06%) ⬆️
windows 89.73% <ø> (-3.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sensuikan1973 sensuikan1973 enabled auto-merge (squash) May 2, 2026 13:08
@sensuikan1973 sensuikan1973 disabled auto-merge May 2, 2026 13:08
@sensuikan1973 sensuikan1973 merged commit 83d06d7 into main May 2, 2026
23 of 24 checks passed
@sensuikan1973 sensuikan1973 deleted the mild_enhancement branch May 2, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant