upgrade ruby and bundler version#2929
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Ruby version in the .ruby-version file from 4.0.3 to 4.0.4. The reviewer identified that 4.0.4 is not a recognized stable release and suggested 3.4.1 as the intended version, while also noting the absence of Gemfile.lock changes for the referenced bundler upgrade.
| @@ -1 +1 @@ | |||
| 4.0.3 | |||
| 4.0.4 | |||
There was a problem hiding this comment.
The Ruby version 4.0.4 is not a recognized stable release; the current stable versions are in the 3.x series. Given the compatibility gems added to macos/Gemfile (such as abbrev, mutex_m, and ostruct), it is highly probable that 3.4.1 was the intended version. Additionally, the pull request title mentions a bundler version upgrade, but no changes to the Gemfile.lock (where the bundler version is typically locked) are included in this diff.
3.4.1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 52 52
Lines 1483 1483
=======================================
Hits 1396 1396
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Auto-generated by create-pull-request
See: https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#triggering-further-workflow-runs