Curve Document #623
Merged
Curve Document #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #623 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 15 15
Lines 3323 3323
Branches 446 446
=======================================
Hits 3305 3305
Misses 12 12
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sadrasabouri
requested changes
Nov 25, 2025
Collaborator
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
I left minor comments.
Comment on lines
+3449
to
+3455
| "source": [ | ||
| "from pycm import PCurve\n", | ||
| "crv = PCurve(actual_vector = numpy.array([1, 1, 2, 2]), probs = numpy.array([[0.1, 0.9], [0.4, 0.6], [0.35, 0.65], [0.8, 0.2]]), classes=[2, 1])\n", | ||
| "crv.thresholds\n", | ||
| "auc_trp = crv.area()\n", | ||
| "auc_trp[1]\n", | ||
| "auc_trp[2]" |
Collaborator
There was a problem hiding this comment.
Shouldn't they be in separate cells with the output? this way the output for intermediate statements.
Owner
Author
There was a problem hiding this comment.
You are right, but I used a previous section's template. It would be better to address this matter in a separate pull request.
Comment on lines
+3496
to
+3501
| "from pycm import RCurve\n", | ||
| "crv = RCurve(actual_vector = numpy.array([1, 1, 2, 2]), probs = numpy.array([[0.1, 0.9], [0.4, 0.6], [0.35, 0.65], [0.8, 0.2]]), classes=[2, 1])\n", | ||
| "crv.thresholds\n", | ||
| "auc_trp = crv.area()\n", | ||
| "auc_trp[1]\n", | ||
| "auc_trp[2]" |
Comment on lines
+3542
to
+3546
| "crv = F1Curve(actual_vector = numpy.array([1, 1, 2, 2]), probs = numpy.array([[0.1, 0.9], [0.4, 0.6], [0.35, 0.65], [0.8, 0.2]]), classes=[2, 1])\n", | ||
| "crv.thresholds\n", | ||
| "auc_trp = crv.area()\n", | ||
| "auc_trp[1]\n", | ||
| "auc_trp[2]" |
sadrasabouri
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#578 #619
What does this implement/fix? Explain your changes.
Any other comments?