Give access to underlying editText view #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi this is more of a suggestion than a full blown PR but I started to use NumberSlidingPicker and I found myself wanting to use input mask and or other extension for EditText (eg https://github.com/RedMadRobot/input-mask-android). Most of them require a either reference to the EditText or extend it through inheritance and changing `editText` visibility help for the first case. I don't have a lot of experience in Java or Kotlin so there might be issues or side effects with my solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this is more of a suggestion than a full blown PR but I started to use NumberSlidingPicker and I found myself wanting to use input mask and or other extension for EditText (eg https://github.com/RedMadRobot/input-mask-android). Most of them require a either reference to the EditText or extend it through inheritance and changing
editTextvisibility help for the first case.I don't have a lot of experience in Java or Kotlin so there might be issues or side effects with my solution.