Refactor transaction models to replace None with empty string for signing public key#107
Open
LimpidCrypto wants to merge 1 commit intodevfrom
Open
Refactor transaction models to replace None with empty string for signing public key#107LimpidCrypto wants to merge 1 commit intodevfrom
LimpidCrypto wants to merge 1 commit intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Implements a better handling of
signing_pub_keywhich is required even if it's just an empty string.Currently
signing_pub_keywas only correctly set when using thenewconstructor. When using the default constructor this is a more straightforward way to indicate to the user, this is a required value.Type of Change