Certificate parser update #1981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classify DER and PEM encoded certificates as this kind of mimetype. Other minor formatting changes were included.
to be expanded and have its certificates extracted as subitems.
as subitems if in format PKCS7 and to be used in conjunction with tika PKCS7Parser.
Merged
Collaborator
Author
|
For testing: |
certification details included.
certificates with full certification path and no CMS signed data.
…t alternative names
…Rs in lib directory
…sidentified as application/x-x509-key)
Collaborator
|
After the changes the result with my sample files are:
In comparison with commit 356689f (prior the last improvements), the results were:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1978
CertificateParser was refactored to extract certificates as subitems. So it can be used in conjunction with tika PKCS7Parser.
Tika PKCS7Parser ignores any certificate information, extracting only the content of the signed PKCS7 file to be parser. So, CertificateParser would be responsible for internal certificates information extraction when configured in conjunction with Tika PKCS7Parser.
To test:
1)User certificates can be exported as p7b files from Windows with full certificate chain. These kind of files will have each certificate extracted as subitem. Though PKCS7Parser will throw an exception as it does not have any content. This exception will be registered in metadata X-TIKA:EXCEPTION:embedded_exception.