-
Notifications
You must be signed in to change notification settings - Fork 290
Pdf reports #2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Pdf reports #2428
Conversation
|
Hi @lfcnassif . Could you please check if the PR is going in the right direction? Just a preview of the result of transforming html into PDF. |
|
Thank you @gfd2020 for working on this PR! Thinking about a best effort approach, converting the current HTML report to PDF, instead of generating a PDF report from scratch using a PDF library (e.g. PDFBox), seems fine to me, at least as a first implementation. It should also make future maintenance easier, because it reuses a lot of the current report code, and that an important aspect to take into account. Maybe @wladimirleite could also comment on this, since he is the original HTMLReport's author. PS: If there are no limitations when comparing to a "create PDF from scratch approach", it is even better! |
It seems a great approach! To be honest, I don't use the HTMLReport myself anymore (i.e. I only send the IPED analysis tool for my cases). But I do understand that the HTML report may be useful in some scenarios. The same applies for a PDF report. Converting the HTML to PDF seems indeed the best approach, as it would provide an alternative way to access the report, without the cost (code + test + maintain) of creating the PDF from the scratch. |
|
I have attached an example of the report in PDF. Although wkhtmltopdf is powerful, it has limitations. So, I did my best to stay as close to the html report. |
This PR exports the IPED html report in PDF format using the wkhtmltopdf program.
Implements Issue #1039