-
Notifications
You must be signed in to change notification settings - Fork 290
AI Filters tab update (#2727) #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR is ready for review. |
|
During my tests changing IPED language I realized that AI filters using the same order in which they appear in 'AIFiltersConfig.json' is a bit strange because it lacks natural text ordering logic. So, I've added support for localized alphabetic sorting of AI Filter tree nodes' children (see commit 905e62b). |
|
@marcosammoura, although I agree that having the sorting option is great, I am not sure we should enable it in the default configuration. |
@wladimirleite, I see your point on using fixed, most important first strategy. Thanks for another view from the user's perspective. I'll revert the change to the config so the default will be the fixed order (see commit 254d293). |
|
Hi @marcosammoura, since this PR depends on #2693, I just merged this PR there, so I'm closing this. |
Closes #2727.