Skip to content

Conversation

@marcosammoura
Copy link
Collaborator

Closes #2727.

@marcosammoura
Copy link
Collaborator Author

PR is ready for review.

@marcosammoura
Copy link
Collaborator Author

marcosammoura commented Nov 25, 2025

During my tests changing IPED language I realized that AI filters using the same order in which they appear in 'AIFiltersConfig.json' is a bit strange because it lacks natural text ordering logic.

So, I've added support for localized alphabetic sorting of AI Filter tree nodes' children (see commit 905e62b).
The solution is very simple, if "sortChildren": "true" exists for a node its children will be sorted in alphabetic order, otherwise nodes' children will be shown using the same order in which they appear in 'AIFiltersConfig.json'.

@wladimirleite
Copy link
Member

@marcosammoura, although I agree that having the sorting option is great, I am not sure we should enable it in the default configuration.
Obviously, it is a personal preference, but the idea of the "fixed" (following the configuration) order was to place together related filters, and put in the top the most important ones (currently, the "Remote Image Classifier").

@marcosammoura
Copy link
Collaborator Author

marcosammoura commented Nov 25, 2025

@marcosammoura, although I agree that having the sorting option is great, I am not sure we should enable it in the default configuration. Obviously, it is a personal preference, but the idea of the "fixed" (following the configuration) order was to place together related filters, and put in the top the most important ones (currently, the "Remote Image Classifier").

@wladimirleite, I see your point on using fixed, most important first strategy. Thanks for another view from the user's perspective. I'll revert the change to the config so the default will be the fixed order (see commit 254d293).

@lfcnassif
Copy link
Member

Hi @marcosammoura, since this PR depends on #2693, I just merged this PR there, so I'm closing this.

@lfcnassif lfcnassif closed this Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AI Filters tab update

4 participants