Fix Discourse deprecation warnings (hbs-extension, resolver-resolutions, static-viewport) - #2
Open
mavi-sqr wants to merge 1 commit into
Open
Fix Discourse deprecation warnings (hbs-extension, resolver-resolutions, static-viewport)#2mavi-sqr wants to merge 1 commit into
mavi-sqr wants to merge 1 commit into
Conversation
…ns, static-viewport) - Convert clean-user-info.hbs to .gjs with ui-kit helper imports (Discourse 2026.9); use dFormatDate, whose medium/title defaults replicate the now- deprecated bound-date helper, so no new deprecation is introduced. - Delete the dead navigation-bar.hbs template override (template overrides were removed from core in June 2025) — clears both hbs-extension and resolver-resolutions for that file. - Drop the deprecated static-viewport `site.mobileView` lookup in init-nav-controls.js. The mobile-only hide-on-scroll effect stays correctly scoped via the existing @media (max-width: 780px) block in common.scss. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Admins on community.seqera.io (Discourse 2026.9.0-latest) see three recurring
"Theme 'Clean' contains code which needs updating" warnings:
discourse.hbs-extensiondiscourse.resolver-resolutionsdiscourse.static-viewport-initializationThese are Discourse deprecations (not the Dependabot/
npm auditfindings — thoseare dev-only lint tooling that never ships to the forum).
.hbssupport is beingremoved in the 2026.8+ line, so this is time-sensitive.
What
clean-user-info.hbs→.gjswith the correct core imports for 2026.9(
discourse/ui-kit/helpers/*,discourse-i18n). Dates usedFormatDate, whosemedium/titledefaults replicate the old{{bound-date}}output exactly — andbound-dateis itself now deprecated, so this avoids trading one warning for another.navigation-bar.hbstemplate override. Template overrides wereremoved from core in June 2025; the file only emitted warnings (its content was the
default nav items plus the already-existing
extra-nav-itemoutlet). Clears bothhbs-extensionandresolver-resolutionsfor that file.site.mobileViewlookup ininit-nav-controls.js. Themobile-only hide-on-scroll effect stays correctly scoped via the existing
@media (max-width: 780px)block incommon.scss(verified — desktop is unaffected).Also cleaned up a mixed package-manager state (stray
package-lock.jsonremoved;yarn.lockrestored).Note on why not merge upstream
LhcflMerging upstream would fix only 2 of 3 warnings, and destructively: upstream deleted
the custom user-info panel (moved to a separate theme-component) and never fixed the
static-viewportcall. Histories have also diverged (15 ahead / 99 behind). Surgicalfixes here clear all three while keeping the Seqera branding.
Verification
ember-template-lintandprettierpass clean on the changed files.Admin → Customize → Themes → Clean shows no deprecation banners for the three IDs,
and check the user-profile panel + navigation render identically (mobile: nav hides on
scroll; desktop: unaffected).
🤖 Generated with Claude Code