Repair benchmark report workflow compatibility - #104
Closed
FloWuenne wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEQERA_RUNS_DUMP/ tarball-based outputs as the canonical execution path and generate the new benchmark HTML from the unpacked run dumps instead of live nf-boost API callsBENCHMARK_REPORT_V2, fix the invalid schema, and resolve the checked-in merge conflict in the PR templateTesting
python3 -m json.tool nextflow_schema.json >/tmp/nfagg_schema_check.jsonpython3 -m py_compile bin/benchmark_report.pynextflow config -flat > /tmp/nfagg_config_flat.txtpython3 bin/benchmark_report.py --dump-dir /tmp/nfagg_sample_dumps --output /tmp/nfagg_benchmark_report.html/opt/cursor/artifacts/benchmark_report_demo.htmlin Chrome and visually verified the rendered Benchmark overview / Run overview sections withgroup1andgroup2nf-test test modules/local/benchmark_report/tests/main.nf.test(fails in this cloud environment becausetwis not available in the test runtime:.command.sh: line 6: tw: command not found)nf-test test workflows/nf_aggregate/tests/main.nf.test(sametwenvironment limitation)nextflow run . -profile test,docker -stub-run --outdir /tmp/nfagg-stub-2(now starts successfully on Nextflow 24.10.4, but still hits an existingSEQERA_RUNS_DUMPstub-run null-clone failure unrelated to the benchmark path)Walkthrough
benchmark_report_desktop_demo.mp4
Benchmark report HTML opens and renders on the desktop.
benchmark report header and overview
benchmark report run overview