Skip to content

Simplify CI workflows and remove nf-core specific checks - #121

Merged
FloWuenne merged 1 commit into
remove_old_processesfrom
claude/review-cicd-pipeline-l4Q6G
Apr 13, 2026
Merged

Simplify CI workflows and remove nf-core specific checks#121
FloWuenne merged 1 commit into
remove_old_processesfrom
claude/review-cicd-pipeline-l4Q6G

Conversation

@FloWuenne

Copy link
Copy Markdown
Contributor

Description

This PR removes several nf-core-specific GitHub Actions workflows and simplifies the linting workflow to focus on code formatting only. The changes reflect a shift away from nf-core pipeline conventions toward a more independent project structure.

Changes Made

  • Removed workflows:

    • download_pipeline.yml - Pipeline download testing workflow
    • fix-linting.yml - Automated linting fix workflow triggered by comments
    • branch.yml - Branch protection workflow enforcing dev branch PRs
    • template_version_comment.yml - nf-core template version checking
    • linting_comment.yml - Automated linting results comment posting
  • Modified linting.yml:

    • Removed nf-core job that ran nf-core pipelines lint
    • Simplified workflow to only run pre-commit checks (prettier, editorconfig-checker)
    • Updated workflow name and description to reflect new purpose
    • Kept only the pre-commit job for code formatting validation
  • Minor formatting fixes:

    • Updated snapshot test file formatting (whitespace normalization)
    • Removed multiqc_config.yml (no longer needed)
    • Fixed markdown table alignment in modules/local/AGENTS.md

Rationale

These changes align the project with its independent status, removing dependencies on nf-core tooling and conventions. The simplified linting workflow maintains code quality through pre-commit checks while removing nf-core-specific validation steps.

PR Checklist

  • This comment contains a description of changes (with reason).
  • Code linting passes (pre-commit checks only).
  • No breaking changes to pipeline functionality.

https://claude.ai/code/session_012Dks8jvRprxGta93t4o72Q

Fixes for the two real CI failures on this branch:
- Reformat modules/local/AGENTS.md to satisfy prettier (pipe-table
  trailing whitespace).
- Update utils_nf_aggregate subworkflow snapshot to drop removed
  'fusion' field from parsed samplesheet meta.

Workflow cleanup, consistent with the removal of MultiQC / Gantt /
SEQERA_RUNS_DUMP in this PR:
- Drop branch.yml (enforces nf-core dev-branch PR convention not used
  by this repo).
- Drop fix-linting.yml (depends on nf-core-bot token/comments).
- Drop template_version_comment.yml (nags about nf-core template
  version; low-value for a seqeralabs-branded pipeline).
- Drop linting_comment.yml (only useful as companion to the nf-core
  pipelines lint job, which is also dropped).
- Drop download_pipeline.yml (tests 'nf-core pipelines download',
  unused install path and 'ci' is already in skip_features).
- Simplify linting.yml to just run pre-commit (drop the nf-core
  pipelines lint job — this is a seqeralabs pipeline, is_nfcore:false,
  and the lint job was currently red).

Housekeeping:
- Delete dangling assets/multiqc_config.yml (no longer referenced
  anywhere after MultiQC removal).
@FloWuenne
FloWuenne merged commit 7ba254d into remove_old_processes Apr 13, 2026
9 checks passed
@FloWuenne
FloWuenne deleted the claude/review-cicd-pipeline-l4Q6G branch April 13, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants