Port PR #132 to current main: add scheduler VM metrics to benchmark reports - #137
Merged
FloWuenne merged 21 commits intoApr 22, 2026
Merged
Conversation
Two CI-breaking issues fixed: 1. NORMALIZE_BENCHMARK_JSONL crashed with 'input file name collision' when both optional inputs (CUR report + machines dir) were absent — both resolved to the same 'NO_FILE' sentinel. Use distinct sentinels: NO_FILE_CUR and NO_FILE_MACHINES. 2. Module-local bin/benchmark_report.py shims were shadowed by the root bin/benchmark_report.py (Typer CLI). Nextflow only adds projectDir/bin/ to PATH, so the argparse shims were never found. Renamed module-local shims to stage-specific names (normalize_benchmark_jsonl.py, etc.) and moved them to root bin/. Worker modules (benchmark_report_normalize.py etc.) are symlinked from root bin/ to module-local bin/. 3. Fixed editorconfig-checker failures: 14 lines in benchmark_report_template.html had odd-number leading spaces.
Contributor
Author
|
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
This reverts commit 00c0a04.
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
chore: exclude realworld logs from prettier
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
ci: gate benchmark report checks by changed files
FloWuenne
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Supersedes / follows up on #132.