Remove stale nf-core template remnants - #141
Conversation
Co-authored-by: Florian Wuennemann <flowuenne@gmail.com>
|
|
||
| - [`nf-core-utils@0.4.0`](https://github.com/nf-core/nf-utils) | ||
|
|
||
| > Ewels PA, Peltzer A, Fillinger S, Patel H, Alneberg J, Wilm A, Garcia MU, Di Tommaso P, Nahnsen S. The nf-core framework for community-curated bioinformatics pipelines. Nat Biotechnol. 2020 Mar;38(3):276-278. doi: 10.1038/s41587-020-0439-x. |
There was a problem hiding this comment.
Don't think the utils plugin has a citation?
There was a problem hiding this comment.
yeah, that's a citation for nf-core in general.
no need for that for plugins, for me the URL is enough.
I would not even put versions as it's a pain to update whenever you update the plugin.
That being said, even if this is now diverging quite a lot from standard nf-core pipeline, I would still keep a general citation to nf-core.
FriederikeHanssen
left a comment
There was a problem hiding this comment.
Thanks for adding the citation back in
maxulysse
left a comment
There was a problem hiding this comment.
minor comments, but LGTM
Move the nf-core framework citation out of the plugin entry and into its own section, consistent with the Nextflow citation above it. Co-Authored-By: Claude <noreply@anthropic.com>
|
OK, I moved the citation for nf-core back to a general nf-core citation and out of nf-core-utils. I agree with @maxulysse that a general nf-core citation should remain, even if the template isn't used anymore! |
PR checklist
CITATIONS.md,README.md, and agent/context guidance in the same PR.nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).Description
Remove stale nf-core template residue that is no longer used, including deleting the leftover
.nf-core.ymlfile that contradicted the repository guidance.Also align plugin documentation and future agent guidance with the actual pinned plugins in
nextflow.configby:nf-core-utils@0.4.0andnf-schema@2.3.0inCITATIONS.mdREADME.mdnf-core CItoPipeline CIso it reflects the current repository setupTesting
uv run --with typer --with pyyaml --with jinja2 --with pyarrow --with pytest --with httpx pytest -v modules/local/aggregate_benchmark_report_data/tests/test_aggregate.py modules/local/normalize_benchmark_jsonl/tests/test_normalize.py modules/local/render_benchmark_report/tests/test_render.py bin/test_benchmark_report_fetch.pynf-test test --profile=+docker --verbosenextflow run . --input workflows/nf_aggregate/assets/test_benchmark.csv --generate_benchmark_report --outdir /tmp/nf-aggregate-e2e-results -profile dockerpre-commit run --all-files