feat: add include_failed_runs benchmark override - #147
Merged
Conversation
Contributor
|
@copilot resolve the merge conflicts in this pull request |
…-runs # Conflicts: # README.md # nextflow.config # nextflow_schema.json Co-authored-by: FloWuenne <11639154+FloWuenne@users.noreply.github.com>
Contributor
Resolved and pushed. I merged |
FloWuenne
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_failed_runs/include-failed-runsoverride for benchmark report generationWhy
When comparing benchmark runs, it is useful to inspect workflow-level failed runs in the downstream HTML sections and charts instead of only seeing them dimmed/excluded in the run summary.
Test plan
UV_NO_CONFIG=1 uv run --with typer --with pyyaml --with jinja2 --with pyarrow --with pytest --with httpx pytest -q modules/local/aggregate_benchmark_report_data/tests/test_aggregate.py::test_failed_and_cancelled_runs_only_appear_in_overview modules/local/aggregate_benchmark_report_data/tests/test_aggregate.py::test_include_failed_runs_override_includes_failed_in_downstream_sectionsUV_NO_CONFIG=1 uv run --with typer --with pyyaml --with jinja2 --with pyarrow --with pytest --with httpx pytest -q modules/local/aggregate_benchmark_report_data/tests/test_aggregate.py modules/local/render_benchmark_report/tests/test_render.pyNotes
tw runs dumptarballs or the aggregate-stage symlink/import issue