feat: [PAY-1007] Parse reference_1 as string to be able to filter lines#42
Merged
feat: [PAY-1007] Parse reference_1 as string to be able to filter lines#42
reference_1 as string to be able to filter lines#42Conversation
zaraheath
changed the title
reference_1 as string to be able to filter linesreference_1 as string to be able to filter lines
igarciasequra
approved these changes
Mar 24, 2025
carlos-benito-sequra
approved these changes
Mar 24, 2025
golive
approved these changes
Mar 24, 2025
golive
reviewed
Mar 24, 2025
| field :amount, 28..41, :integer | ||
| field :document_number, 42..51, :integer | ||
| field :reference_1, 52..63, :integer | ||
| field :reference_1, 52..63 |
Member
There was a problem hiding this comment.
nitpick (non-blocking): I suggest better being explicit and put :string in both references
Contributor
Author
There was a problem hiding this comment.
I just copied the style of other places, there are more references that will need to change in other files, so I won't change them for now
ferranpm
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
reference_1as string instead of integer (most references come as string) to be able to filter by that reference