simplewallet: hide legacy ring-signature UX in FCMP++ wallets - #308
Open
jeetrex17 wants to merge 23 commits into
Open
simplewallet: hide legacy ring-signature UX in FCMP++ wallets#308jeetrex17 wants to merge 23 commits into
jeetrex17 wants to merge 23 commits into
Conversation
jeetrex17
marked this pull request as ready for review
April 4, 2026 20:03
Implement new relay logic with threshold-based peer dropping, single-peer
tx hash requests, per-connection in-flight limits with queuing, and
multiindex-based request tracking. Consolidate add/remove request paths,
pass tx hashes directly into send_txs/relay_txs, and add unit tests for
the request manager.
Co-authored-by: j-berman <justinberman@protonmail.com>
Co-authored-by: Boog900 <boog900@tutanota.com>
Co-authored-by: jeffro256 <jeffro256@tutanota.com> Co-authored-by: Luke Parker <lukeparker5132@gmail.com> Co-authored-by: Lee *!* Clagett <code@leeclagett.com> Co-authored-by: SyntheticBird45 <someoneelse.is_on.github.rio7x@simplelogin.com> Co-authored-by: jeetrex17 <jeetrex@tutamail.com> Co-authored-by: UkoeHB <ukoehb@users.noreply.github.com>
This reverts commit e7fb6ab.
…mp++ Use latest FCMP++ lib changes
n_tree_layers is safe as a uint8_t, varint not necessary
Collaborator
|
Needs rebase |
…eight Bump FCMP++ reference tx weight as a result of larger proofs
Include FCMP_PLUS_PLUS_MAX_TX_WEIGHT
jeetrex17
force-pushed
the
fcmp-wallet-ux
branch
from
April 21, 2026 10:09
1d8b6b6 to
b7973eb
Compare
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FCMP++ wallets still expose some legacy ring-signature UX in
simplewallet.This patch cleans this up by hiding ring-signature-specific prompts and help text when FCMP++ rules are active, while
leaving legacy-wallet behavior unchanged.
In particular:
setoptions that do not apply to FCMP++print_ringhandling for FCMP++ transactionsring_sizearguments in help/usage for:transfersweep_allsweep_accountsweep_belowsweep_singledonateThis updates
help <command>,help all,apropos, and the empty-argument usage paths for those commands.