tx relay v2: tell peer missed requested txs - #378
Closed
j-berman wants to merge 7 commits into
Closed
Conversation
Implement new relay logic with threshold-based peer dropping, single-peer
tx hash requests, per-connection in-flight limits with queuing, and
multiindex-based request tracking. Consolidate add/remove request paths,
pass tx hashes directly into send_txs/relay_txs, and add unit tests for
the request manager.
Co-authored-by: j-berman <justinberman@protonmail.com>
Co-authored-by: Boog900 <boog900@tutanota.com>
Co-authored-by: jeffro256 <jeffro256@tutanota.com> Co-authored-by: Luke Parker <lukeparker5132@gmail.com> Co-authored-by: Lee *!* Clagett <code@leeclagett.com> Co-authored-by: SyntheticBird45 <someoneelse.is_on.github.rio7x@simplelogin.com> Co-authored-by: jeetrex17 <jeetrex@tutamail.com> Co-authored-by: UkoeHB <ukoehb@users.noreply.github.com>
* wallet: saner hf version validity check for FCMP++ * Revert optional args RPC * Update src/wallet/wallet2.cpp Co-authored-by: Jeffro <jeffro256@tutanota.com> --------- Co-authored-by: Jeffro <jeffro256@tutanota.com>
j-berman
force-pushed
the
tell-peer-missed-txs
branch
from
May 13, 2026 01:27
0a61b18 to
56f5ace
Compare
This was referenced Jul 13, 2026
Collaborator
Author
|
Closing in favor of #450 (which includes the same functionality in a more efficient way) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a theory that nodes may be banning peers in #373 because of the following sequence of events:
This PR makes sure that Node A responds to Node B in step 5 saying that it does not have the tx in its pool. Thus Node B knows not to ban Node A, and Node B can proceed to request the tx from another node that may have notified it of the tx in the tx request queue checker loop.
Note: it's also possible for a Node A to sync faster than Node B, and to add a block including that new tx to its chain before Node B does, and then Node B thinks Node A missed the tx request. This PR would solve for that too (as indicated in the comment).
We can wait to move forward with this until we see evidence of this theory actually leading to banned peers.