fcmp_pp: get_output_ref_hash: fix aliasing, endianness, and 32-bit - #403
Open
jeffro256 wants to merge 1 commit into
Open
fcmp_pp: get_output_ref_hash: fix aliasing, endianness, and 32-bit#403jeffro256 wants to merge 1 commit into
jeffro256 wants to merge 1 commit into
Conversation
Collaborator
|
The variant index issue is addressed in #89 by using the output pair type instead of the variant index. Seems a saner cross-platform solution to use our own known indexing scheme to me |
jeffro256
force-pushed
the
fix_get_output_ref_hash
branch
from
July 6, 2026 05:44
dbe2105 to
6d9faaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variant_indexsize was different (4) on 32-bit systems. Its bytes were swapped on big-endian systems. And(crypto::public_key&)commitmentis a strict aliasing violation.