Add SSL support to P2P [beta-stressnet] - #410
Open
vtnerd wants to merge 1 commit into
Open
Conversation
Author
|
Force pushed a fix to the functional tests. |
vtnerd
force-pushed
the
seraphis/beta-ssl
branch
from
June 13, 2026 00:34
23eff78 to
2e2acc6
Compare
Author
|
Force pushed a change mentioned by @selsta on the related patch into |
vtnerd
force-pushed
the
seraphis/beta-ssl
branch
from
June 13, 2026 15:06
2e2acc6 to
b3d5c75
Compare
Author
|
Force pushed the fix for the |
Author
|
The rebase is super simple, but the functional tests are somehow broken. This could take a while as the cause isn't immediately obvious. |
vtnerd
force-pushed
the
seraphis/beta-ssl
branch
from
July 19, 2026 20:36
b3d5c75 to
2149eb4
Compare
Author
|
The issue appears to have been in the functional tests, rather than the ssl code. Hopefully another test fix will not be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the SSL PR on
monero-project/monero/masterbut againstseraphis-migration/monero/fcmp++-beta-stressnet. This includes all review requests, except @selsta recommendation to improve parsing of fingerprints. I didn't include it because it needs some more work beyond the recommendation in that review.