don't punish honest peer on reorg - #442
Open
auruya wants to merge 1 commit into
Open
Conversation
Collaborator
|
Looks related to #374 |
Author
|
yes @j-berman , also before the fix during a reorg missing txs never requested from peer since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently on reorg, if there is missing tx in a block of the alt chain we trying to switch to, we fail to add the block which had the missing tx in our pool and we ban the honest sending peer, although we only failed to verify the block since we dropped its txs from our pool. This PR fixes that by correctly copying the
missing_txsflag back tohandle_notify_new_fluffy_blockwhere we check whether the missing tx from the last block we are trying to add or from an ancestor block. If its from an ancestor block we re-request the reorg blocks so we get the blocks and their txs completely.