Skip to content

don't punish honest peer on reorg - #442

Open
auruya wants to merge 1 commit into
seraphis-migration:fcmp++-beta-stressnetfrom
auruya:fix-reorg-bug
Open

don't punish honest peer on reorg#442
auruya wants to merge 1 commit into
seraphis-migration:fcmp++-beta-stressnetfrom
auruya:fix-reorg-bug

Conversation

@auruya

@auruya auruya commented Jul 21, 2026

Copy link
Copy Markdown

currently on reorg, if there is missing tx in a block of the alt chain we trying to switch to, we fail to add the block which had the missing tx in our pool and we ban the honest sending peer, although we only failed to verify the block since we dropped its txs from our pool. This PR fixes that by correctly copying the missing_txs flag back to handle_notify_new_fluffy_block where we check whether the missing tx from the last block we are trying to add or from an ancestor block. If its from an ancestor block we re-request the reorg blocks so we get the blocks and their txs completely.

@j-berman

Copy link
Copy Markdown
Collaborator

Looks related to #374

@auruya

auruya commented Jul 22, 2026

Copy link
Copy Markdown
Author

yes @j-berman , also before the fix during a reorg missing txs never requested from peer since missing_txs weren't set to true. So the problem existed even missing txs only existed on the last received alt chain block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants