-
Notifications
You must be signed in to change notification settings - Fork 27
I18n support for notifications #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/log-rework
Are you sure you want to change the base?
I18n support for notifications #100
Conversation
968881c to
9660e21
Compare
|
I uploaded a change as a new proposal for error messages, which includes a way to automatically setup and print error code. Demanding further discussion. |
…when not connected (seraxis#169)
…M float WAV files. Closes seraxis#175
Restructure the contributor aimed portion of the document to address common development pitfalls
# Conflicts: # core/src/bms/player/beatoraja/select/MusicSelector.java
|
In most recent commit 0eb5b5f I filled several requirements from #159:
Here's a small explanation of the implementation: I added a class named The actual translation is happened inside the class There's one drawback of this implementation: we need to replace all |
0eb5b5f to
7428275
Compare
|
Update: error code mechanism is reimplemented. Marking this pr as ready for review because it is now demanding discussion around the designs. If there's no issues about the design I'll be going to process the migration. |
1680dff to
9bd3200
Compare
This is a proposal for how we implement the i18n support for the in-game notifications:
UIResources.properties&ResourceBundlemechanism. This commit adds 3 messages for example, one is a simple welcome message, two are IR send success/failed messages.