-
Notifications
You must be signed in to change notification settings - Fork 27
LR2ArenaEx port #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
LR2ArenaEx port #120
Conversation
seraxis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review, more to follow
c73ca73 to
d0289f0
Compare
|
In most recent commit, server side & network transfer pojo class definitions are moved into a standalone repo JLR2ArenaEx. Leaving only client side implementation in this pr to help the reviewers. |
|
Hello, I recently encountered an issue while using the game: after opening the Endless Dream Mod menu, all keyboard inputs will be banned sometimes, I have to restart the game to make it work again. Using the areneEX, pre release 0.3.1 version. Playing with IIDX controller. Thank you |
It's an intentional behavior if you're focusing the arena/skin widget manager menu. Otherwise it's an issue Edit: for arena menu, it would disable your inputs if it's focused. skin widget manager menu is always disabling your inputs when it's checked. Try closing the arena menu or click somewhere else to make it unfocus and see if the problem continues |
I just did some detailed testing today. Most of the parts work as you mentioned. However, I still encountered the same bug with the 'Show Arena Menu' submenu. |
I did encounter the same bug before, I'll try to fix it and update tomorrow. Thank you for your feedback :) |
|
@DDD0s Updated at https://github.com/Catizard/lr2oraja-endlessdream-arenaex/releases/tag/pre-release. Should be fixed :) |
In short, this pr brings the functionality:
These are some improvements, which might not be implemented under this pr:
Known bugs: