Allow player customize game's resolution #133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seraxis
requested changes
Oct 20, 2025
Owner
seraxis
left a comment
seraxis
left a comment
There was a problem hiding this comment.
Great work, though it seems like skins can behave incredibly strangely at uncommon (21:9, 5:4) or extreme aspect ratios. Not sure if this is something we could address for this feature or not
core/src/bms/player/beatoraja/launcher/VideoConfigurationView.fxml
Outdated
Show resolved
Hide resolved
core/src/bms/player/beatoraja/launcher/VideoConfigurationView.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is already working but the implementation is smelling, it's hard to keep the
Resolutionenum & drop-in compatibility. Waiting discussion.This pr is suspended until we can find a way to keep the compatibility between uncommon resolution setting & skins.