Per column judge count #171
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167
Demanding further discussion:
Implementation details:
This pr introduces a new class
JudgeCountTracker, which can be viewed as a blackbox for tracking the current judge details. It's created with theJudgeManager, which means it's created at each time player starting a new chart. And after creation it's passed as a readable reference toJudgeTrainerand be used as the datasource for displaying the current judge details.As you can see this tracker's lifetime is manually designed, which causes some extra data are not very easy to record. For example, the count of the inputs that are ignored by the internal
durationdesign for each columns.