Storing #LNMODE scores in the current player LN mode score cache #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the 0.4 issue of disappearing scores (#178),
Alleviates an issue where scoring on a chart that was added to the database using the old parser that allowed #LNMODE would cause the score cache to write and read from different cache blocks
I've provided a more detailed explanation of the score cache behaviour and the mechanics of this fix in internal dev channel, reproduced here:
Incidentally, the new score could still be seen by opening the context menu, because that song bar was created using a different song data object - one that was reloaded by the
renderfunction inMusicSelector- which, since it needs to generate the note graph, would re-parse the chart and load the score with the rightfeature.This last fix is the one provided by this PR.