refactor(JS): Encapsulated JS in a module instead of using the gobal scope#82
Open
JBBianchi wants to merge 4 commits intoserdarciplak:masterfrom
Open
refactor(JS): Encapsulated JS in a module instead of using the gobal scope#82JBBianchi wants to merge 4 commits intoserdarciplak:masterfrom
JBBianchi wants to merge 4 commits intoserdarciplak:masterfrom
Conversation
Owner
|
Thanks for this PR. As this is a breaking change, I'll merge these changes in v4.0.0 |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor encapsulate the JS code in its own module instead of using the global scope which could be tampered with.
Important notice, support for dotnet standard 2.0 has been dropped because of the use of
IJSObjectReference.The JS has been cleaned a bit:
thisvar, enforced proper use ofconst/let(it was used randomly)editorfor instance)===/!==instead of==/!=).