Fix transport compression #3462
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't run
cargo fmt --allbecause it formatted tens of files, maybe that should be done in another PR.From my own testing, both zlib and zstd work now.
I also enabled the
stdfeature of thezstd-safecrate so that we don't have to manually manage the buffer, hope that's ok.Before these changes the decompressed buffer had 64KB of fixed size, so larger messages would be truncated and that caused the parsing errors.
The code before for zlib also assumed decompression happened in one call, but
flate2::Decompress::decompress_vecdoesn't manage the vec so it only writes as much as it can currently fit in it.