Move benchmarks outside pythran package#2403
Move benchmarks outside pythran package#2403stratakis wants to merge 1 commit intoserge-sans-paille:masterfrom
Conversation
|
Discovered it while trying to update to the latest version in Fedora. Since there was no an |
|
It seems pytest might still be collecting this file, changing to draft for a bit till I properly test it. |
The test_ prefix of the benchmark file was making pytest collect it and use the benchmarks directory as root, having the tests failing. Rename the file so it's not collected via the usual pytest runs.
|
ack. Just so you know I removed codspeed integration recently, so don't worry too much about integration. I do run benchmark tests locally through PYTHONPATH=$PWD py.test pythran/benchmarks/test_benchmark.py -v |
|
Changing the name of the file so pytest doesn't collect it, hence it won't change directory seems to work. My initial assumptions of the lack of an init file was not correct, the file naming scheme was the culprit. Already tested in Fedora and tests run successfully. |
|
Seems that I'm not able to change the title of the PR, but the commit message should be relevant. |
The test_ prefix of the benchmark file was making
pytest collect it and use the benchmarks directory as
root, having the tests failing.
Rename the file so it's not collected via the usual
pytest runs.