Skip to content

Conversation

@sergelogvinov
Copy link
Owner

@sergelogvinov sergelogvinov commented Jan 27, 2026

Pull Request

What? (description)

Redefine the default service account name using environment variables.

Why? (reasoning)

fix: #274

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you linted your code (make lint)
  • you linted your code (make unit)

See make help for a description of the available targets.

Summary by CodeRabbit

  • New Features

    • Added support for dynamic service account configuration via the SERVICE_ACCOUNT environment variable, enabling flexible deployment scenarios while maintaining backward compatibility with default values.
  • Chores

    • Updated chart version to 0.2.25.

✏️ Tip: You can customize this high-level summary in your review settings.

Redefine the default service account name using environment variables.

Signed-off-by: Serge Logvinov <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

This pull request updates the Proxmox Cloud Controller Manager chart version from 0.2.24 to 0.2.25. The deployment template is modified to introduce a new SERVICE_ACCOUNT environment variable that exposes the pod's service account name to the container. The cloud.go package is updated to read this environment variable at runtime, with a fallback to the existing hardcoded service account name if the variable is not set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: introducing environment-variable-driven service account selection in the cloud controller manager.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sergelogvinov sergelogvinov merged commit 88fad84 into main Jan 27, 2026
5 checks passed
@sergelogvinov sergelogvinov deleted the sa-name branch January 27, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcoded SA name must be valid with kubernetes

2 participants