Fix OpenAPS pill and forecast lines disappearing on missing rate field#3
Open
sergev-art wants to merge 1 commit intomasterfrom
Open
Fix OpenAPS pill and forecast lines disappearing on missing rate field#3sergev-art wants to merge 1 commit intomasterfrom
sergev-art wants to merge 1 commit intomasterfrom
Conversation
…ected data is present in lastEnacted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an intermittent bug where the OpenAPS status pill stops updating and forecast lines vanish from the dashboard. Root cause:
lastEnactedobjects from certain OpenAPS configurations do not include aratefield, causing an unhandled reference error that crashes the plugin.lib/plugins/openaps.js— null-safe access tolastEnacted.rateUpstream: nightscout#8324
Design Control Impact
Modified Requirements
lastEnacteddevice status objects without crashingNew Test Cases
openaps.missingPill.test.js: Verifies plugin renders correctly withlastEnactedmissingratefieldmissingRateOnLastEnacted.json,statusWithWorkingForecast.jsonRisk Items
Files Changed (4)
lib/plugins/openaps.jslastEnacted.ratetests/openaps.missingPill.test.jstests/data/missingRateOnLastEnacted.jsontests/data/statusWithWorkingForecast.json