chore(docs): adjust server side instructions in README #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README to clarify entry-server.tsx configuration and code changes.
sergiodxa
reviewed
Oct 17, 2025
Comment on lines
+393
to
+395
| - loadContext: AppLoadContext, | ||
| - // If you have middleware enabled: | ||
| - // loadContext: RouterContextProvider |
Owner
There was a problem hiding this comment.
Middleware is required for remix-i18next so there's no scenario where the user may not have middleware enabled
Author
There was a problem hiding this comment.
Yes and therefore everything removed from the boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example code in the README is not based on the most recent version of entry.server.node.tsx
Some examples:
https://github.com/remix-run/react-router/blob/64f82f1581bd5e72a9312802c60bb61b9278135a/packages/react-router-dev/config/defaults/entry.server.node.tsx#L17-L19
https://github.com/remix-run/react-router/blob/64f82f1581bd5e72a9312802c60bb61b9278135a/packages/react-router-dev/config/defaults/entry.server.node.tsx#L34-L37
Updated the code from a full file to a patch because it's easier to understand the actual changes and apply accordingly based on the setup and version used.