Skip to content

Commit 61a698a

Browse files
committed
Use coverlet.collector 10.0.2-preview.28.gf549c8bb24
This solves the coverage issue reported in coverlet-coverage/coverlet#1969
1 parent 88ed4ad commit 61a698a

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

NuGet.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
<packageSources>
44
<clear />
55
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
6+
<add key="coverlet-nightly" value="https://pkgs.dev.azure.com/tonerdo/coverlet/_packaging/coverlet-nightly/nuget/v3/index.json" />
67
</packageSources>
78
</configuration>

src/Log4NetTextFormatter.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,7 @@ internal static string DefaultMessageFormatter(LogEvent logEvent, IFormatProvide
160160
// https://github.com/serilog/serilog-extensions-logging/blob/v9.0.1/src/Serilog.Extensions.Logging/Extensions/Logging/EventIdPropertyCache.cs#L58-L73
161161
var isMicrosoftExtensionsLoggingEvent = logEvent.Properties.TryGetValue(EventIdPropertyName, out var property)
162162
&& property is StructureValue structure
163-
// ReSharper disable once MergeIntoLogicalPattern -- Wrong coverage report, see https://github.com/coverlet-coverage/coverlet/issues/1969
164-
&& structure.Properties.Any(e => e.Name == "Id" || e.Name == "Name");
163+
&& structure.Properties.Any(e => e.Name is "Id" or "Name");
165164

166165
if (isMicrosoftExtensionsLoggingEvent)
167166
{

tests/Serilog.Formatting.Log4Net.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<ItemGroup>
99
<PackageReference Include="AwesomeAssertions" Version="9.4.0" />
10-
<PackageReference Include="coverlet.collector" Version="10.0.1" PrivateAssets="all" />
10+
<PackageReference Include="coverlet.collector" Version="10.0.2-preview.28.gf549c8bb24" PrivateAssets="all" />
1111
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.7.0" />
1212
<PackageReference Include="PublicApiGenerator" Version="11.5.4" />
1313
<PackageReference Include="ReportGenerator" Version="5.5.10" PrivateAssets="all" />

0 commit comments

Comments
 (0)