Add log event properties to eventhubdata#18
Add log event properties to eventhubdata#18ahmagdy wants to merge 3 commits intoserilog-contrib:devfrom
Conversation
Eventhub data will always ignore logevent properties , it will be passed to eventhub data.
|
Hey @ahmad-magdy thanks for stopping by. Looks like this attempts to address #9. I think would be safer if there was a way to opt-in to adding properties. I wonder if we can take inspiration from any other sinks that have a similar behaviour implemented? Would you be interested in designing such a feature? |
|
Hi @adamchester |
Add EventDataExtension method to use logevent properties
|
@adamchester What do you think about now? |
|
@ahmad-magdy sorry for the delay in replying here. What I meant was I think there needs to be a way to allow the user of the sink to decide which properties will be added as event hub properties and which ones will be in the payload. I wonder if we can come up with simple way to achieve that? |
EventHub Data will always ignore
LogEventProperties, this PR will pass and allow EventHubData to use them.LogEvent properties can contain a lot of additional information from the program and it will be usually used with Sentry or other Serilog Sinks.