feat: add query parameters management#198
Open
followynne wants to merge 10 commits intoserilog-contrib:masterfrom
Open
feat: add query parameters management#198followynne wants to merge 10 commits intoserilog-contrib:masterfrom
followynne wants to merge 10 commits intoserilog-contrib:masterfrom
Conversation
Co-authored-by: mo-esmp <1659032+mo-esmp@users.noreply.github.com>
Co-authored-by: mo-esmp <1659032+mo-esmp@users.noreply.github.com>
Co-authored-by: mo-esmp <1659032+mo-esmp@users.noreply.github.com>
Co-authored-by: mo-esmp <1659032+mo-esmp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes I made were (#192):
instead of simple query-string parse/set, I changed the flow the application uses to manage the search state:
when a value changes, the URL is updated and the app reflects it in its internal state (and viceversa)
source of truth becomes the URL
URL updates and is included in the browser history (moving back and forth the browser history is reflected in the parameters and in the application)
I added a table-key set on query completion (it should fix #195!)