docs: fix KeyError in batch async searches README example#88
Open
danishashko wants to merge 1 commit intoserpapi:masterfrom
Open
docs: fix KeyError in batch async searches README example#88danishashko wants to merge 1 commit intoserpapi:masterfrom
danishashko wants to merge 1 commit intoserpapi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71
The Batch Asynchronous Searches example in the README fails with
KeyError: 'search_metadata'becausesearch.get_search_archive(search_id)is called on the originalsearchobject, which still has all the query params from the initial search loop (includingq,location,async, etc.).When those params are passed to the Search Archive API, it treats them as a new search request and returns an error response like:
{'error': 'You are using queryqparameter on our Search Archive API...'}Fix: use
GoogleSearch({}).get_search_archive(search_id)instead, which is already the pattern shown correctly in the Search Archive API section of this same README.