This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Add a link to the GitHub repository for queue#8
Closed
edunham wants to merge 1 commit intoservo:masterfrom
Closed
Conversation
This adds a link back to the GitHub repository for a project, from the queue.
|
Copying over comment from other PR... It looks like I'm not familiar enough yet with the +++ b/homu/html/queue.html
@@ -30,7 +30,7 @@
</style>
</head>
<body>
- <h1>Homu queue - {{repo_label}}</h1>
+ <h1>Homu queue - {{repo_url}}</h1>
<p>
<button type="button" id="rollup">Create a rollup</button>
diff --git a/homu/server.py b/homu/server.py
index 25f06fa..66dd66a 100644
--- a/homu/server.py
+++ b/homu/server.py
@@ -81,6 +81,7 @@ def queue(repo_label):
})
return g.tpls['queue'].render(
+ repo_url = g.repos[repo_label].html_url,
repo_label = repo_label,
states = rows,
oauth_client_id = g.cfg['github']['app_client_id'],Edit: The above actually won't work as the |
Manishearth
pushed a commit
that referenced
this pull request
Apr 29, 2016
This is an alternate implementation of PR #8. If the user is looking at the special "all" queue page no link will be shown.
|
Move to close |
Author
|
I'm trying to clear out the PR queue in order to do some refactoring. I've captured the fact that this enhancement would be nice to add eventually in #99. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR ported from 84. Originally submitted by @mrmonday on Sun Jun 14 16:01:12 2015.
This adds a link back to the GitHub repository for a project, from the queue.