Skip to content

Add checkmark pseudo element #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukewarlow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add checkmark pseudo element #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions style/servo/selector_parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ pub enum PseudoElement {
// Private, Servo-specific implemented pseudos. Only matchable in UA sheet.
ServoTextControlInnerContainer,
ServoTextControlInnerEditor,
ServoCheckmark,

// Other Servo-specific pseudos.
ServoAnonymousBox,
Expand Down Expand Up @@ -98,6 +99,7 @@ impl ToCss for PseudoElement {
Marker => "::marker",
ColorSwatch => "::color-swatch",
Placeholder => "::placeholder",
ServoCheckmark => "::-servo-checkmark",
ServoTextControlInnerContainer => "::-servo-text-control-inner-container",
ServoTextControlInnerEditor => "::-servo-text-control-inner-editor",
ServoAnonymousBox => "::-servo-anonymous-box",
Expand Down Expand Up @@ -248,6 +250,7 @@ impl PseudoElement {
| PseudoElement::DetailsSummary
| PseudoElement::Marker
| PseudoElement::Placeholder
| PseudoElement::ServoCheckmark
| PseudoElement::ServoTextControlInnerContainer
| PseudoElement::ServoTextControlInnerEditor => PseudoElementCascadeType::Lazy,
PseudoElement::DetailsContent
Expand Down Expand Up @@ -632,6 +635,12 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> {
"backdrop" => Backdrop,
"selection" => Selection,
"marker" => Marker,
"-servo-checkmark" => {
if !self.in_user_agent_stylesheet() {
return Err(location.new_custom_error(SelectorParseErrorKind::UnexpectedIdent(name.clone())))
}
ServoCheckmark
},
"-servo-details-summary" => {
if !self.in_user_agent_stylesheet() {
return Err(location.new_custom_error(SelectorParseErrorKind::UnexpectedIdent(name.clone())))
Expand Down