Skip to content

Conversation

@yezhizhen
Copy link
Member

@yezhizhen yezhizhen commented Jan 25, 2026

Servo Companion: servo/servo#42136

Note that registered properties don't animate correctly: #38

Copy link
Collaborator

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't address servo/servo#41417 (comment)

@yezhizhen
Copy link
Member Author

This doesn't address servo/servo#41417 (comment)

But can't we leave it as a follow up? It is set as non-animatable in the fixup commits anyway, so shouldn't cause crash.

@yezhizhen
Copy link
Member Author

But can't we leave it as a follow up? It is set as non-animatable in the fixup commits anyway, so shouldn't cause crash.

https://github.com/servo/servo/actions/runs/21329329850

There is no crash thanks to the fixup you proposed. So it is good for now?

@Loirooriol
Copy link
Collaborator

As a rule of thumb , features shouldn't be enabled until they are properly implemented, because otherwise it defeats feature checking and it can end up breaking more than it fixes.

But we don't supports @supports at-rule(), so maybe it's fine.

Still, thinking long-term I would like to do these king of things with experimental flags, which I don't think is currently possible for Stylo static prefs.

@yezhizhen yezhizhen requested a review from mrobinson January 27, 2026 10:43
@yezhizhen yezhizhen force-pushed the test-property branch 2 times, most recently from 03b4263 to 0cc6b20 Compare January 29, 2026 02:36
Signed-off-by: Euclid Ye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants