-
Notifications
You must be signed in to change notification settings - Fork 64
Enable layout.css.properties-and-values.enabled
#293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Loirooriol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't address servo/servo#41417 (comment)
But can't we leave it as a follow up? It is set as non-animatable in the fixup commits anyway, so shouldn't cause crash. |
https://github.com/servo/servo/actions/runs/21329329850 There is no crash thanks to the fixup you proposed. So it is good for now? |
|
As a rule of thumb , features shouldn't be enabled until they are properly implemented, because otherwise it defeats feature checking and it can end up breaking more than it fixes. But we don't supports Still, thinking long-term I would like to do these king of things with experimental flags, which I don't think is currently possible for Stylo static prefs. |
03b4263 to
0cc6b20
Compare
Signed-off-by: Euclid Ye <[email protected]>
0cc6b20 to
b3455e6
Compare
Servo Companion: servo/servo#42136
Note that registered properties don't animate correctly: #38