Skip to content

Fix typo in selectors README#379

Open
VladNegara wants to merge 1 commit into
servo:mainfrom
VladNegara:selectors-readme-typo
Open

Fix typo in selectors README#379
VladNegara wants to merge 1 commit into
servo:mainfrom
VladNegara:selectors-readme-typo

Conversation

@VladNegara
Copy link
Copy Markdown

I noticed a typo in the README file of the selectors library.

Signed-off-by: Vlad Negară <150728638+VladNegara@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't specific to Servo, can you send this directly to upstream Firefox?

If it lands here, I will need to export it anyways (which isn't a big deal if you aren't familiar with Firefox contributions)

@VladNegara
Copy link
Copy Markdown
Author

I'm not familiar with Firefox contributions. If the process isn't too involved, could you point me in the right direction?

@Loirooriol
Copy link
Copy Markdown
Collaborator

See https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html for a guide.

In this case you don't need to build. Also downloading the entire history would be overkill, I think git clone --depth 1 https://github.com/mozilla-firefox/firefox/ should suffice to get the code.

With the code, just do the change, and commit. You should probably link the commit to a bug in https://bugzilla.mozilla.org/, e.g. using Bug XXXXXX - Fix typo in selectors README. r?#style as a commit title.

Then submit it according to https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch.

If that's too tedious, it's fine to just land it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants